Use ImGui's native DPI scaling.#902
Merged
azonenberg merged 1 commit intongscopeclient:masterfrom Sep 23, 2025
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #868. It also fixes an issue I was seeing where the scaling factor set in the OS was being rounded to the nearest integer factor (e.g. I use a 165% scaling factor, but ngscopeclient was rendering at 200%).
Dear ImGui added native support for DPI scaling in release 1.92 (June 2025). See their new FAQ entry on DPI handling. That feature is still experimental and so it could break on future ImGui updates, but it seems to work much better than what we were doing before.
It looks like the ImGUI GLFW backend already has the necessary conditionals to disable scaling on macOS, so I didn't disable the DPI awareness settings on that platform like we did before.