Migrate to FFTW from FFTS inside unit tests#900
Merged
azonenberg merged 1 commit intongscopeclient:masterfrom Sep 24, 2025
Merged
Migrate to FFTW from FFTS inside unit tests#900azonenberg merged 1 commit intongscopeclient:masterfrom
azonenberg merged 1 commit intongscopeclient:masterfrom
Conversation
helaslo
commented
Sep 22, 2025
| @@ -1,5 +1,4 @@ | |||
| ../LICENSE | |||
| ../../ffts/COPYRIGHT | |||
Contributor
Author
There was a problem hiding this comment.
Not sure how shall I place the license here for FFTW
Contributor
Author
There was a problem hiding this comment.
I mean since it is test-case only, shall it be included?
Collaborator
There was a problem hiding this comment.
We actually don't display licenses in the MSI installer (and FFTS isn't shipped in the binary) so that entire file is legacy and can probably be removed but I need to verify. Deleting that line is fine.
| ${LIBFFTS_LIBRARIES} | ||
| ) | ||
|
|
||
| pkg_search_module(FFTW fftw3f IMPORTED_TARGET) |
Contributor
Author
There was a problem hiding this comment.
I haven't seen this way of including PkgConfig modules elsewhere in the codebase, is it okay this way?
tests/Filters/Filter_DeEmbed.cpp
Outdated
|
|
||
| //Apply the interpolated S-parameters | ||
| for(size_t j=0; j<nouts; j++) | ||
| for(size_t j = 0; j < sines.size(); j++) |
Contributor
Author
There was a problem hiding this comment.
Changed this because ASAN was failing in the old way, although tests ran fine otherwise. Not sure if mathematically this is still correct, but the tests are passing.
Interesting thing is that valgrind wasn't complaining either way, and if I didn't execute any FFTW function ASAN didn't find any problems either.
Contributor
Author
|
CI seems to pass now aside from the random macOs failure, grepping for FFTS and ffts both shows no results except inside VkFFT I think it can be merged now. Companion PR for docs is ngscopeclient/scopehal-docs#108 |
helaslo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes ngscopeclient/scopehal#757
There are some things that I wasn't sure about, I will mark them inside the code comment region after the PR is submitted, the most notable is that I changed nouts to sines.size() inside the DeEmbed filter test, because otherwise ASAN complained, although the tests ran fine either way.
Windows CI started to fail, but it seems like clang is being more aggressive with some imgui internal function, in other platform it builds fine.