Siglent driver update for latest SDS firmwares#1023
Merged
azonenberg merged 10 commits intongscopeclient:masterfrom Dec 9, 2025
Merged
Siglent driver update for latest SDS firmwares#1023azonenberg merged 10 commits intongscopeclient:masterfrom
azonenberg merged 10 commits intongscopeclient:masterfrom
Conversation
Updated SDS2000X HD driver for 1.2.3.1 firmware version (no longer needs size workaround + new version string pattern with uboot patch version number). Added sanity check on return waveform data size to prevent buffer overflows when the scope reports an inconsistent size.
Fixed some sample rate change issues.
Fixed concurrent access when changing sample rate while acquisition is running. Fixed sample depth modification for E11 protocol.
Collaborator
Contributor
Author
|
Well up to you @azonenberg , but I think you can merge it as it is : it already fixes a good part of the problems reported in #1016 (at least the ones that I was able to reproduce on my SDS2000X HD) + it adds support for the latest SDS2000X HD firmware. |
Collaborator
|
OK so ready to merge but we'll keep #1016 open until confirmed separately? Got it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
This PR is an update of Siglent driver for latest SDS firmwares (aka E11 protocol).
It's been tested on my SDS 2000X HD after updating to latest 1.2.3.1 firmware (from 11/4/2025).
This firmware version comes with a few changed:
This PR also fixes other issues reported here : #1016
Other fixes:
Please let me know if you have any comment.
Best,
Frederic.