RFC: feat: Support multiple networks by running multiple instances of nginx-proxy#2660
Closed
p12tic wants to merge 1 commit into
Closed
RFC: feat: Support multiple networks by running multiple instances of nginx-proxy#2660p12tic wants to merge 1 commit into
p12tic wants to merge 1 commit into
Conversation
This is useful in cases there are multiple networks to be managed with nginx-proxy on the same host. For example, a public network and a network that can only be reached through a VPN. This commit makes it possible to use multiple instances of nginx-proxy in such use cases. Each instance has a separate "namespace" of VIRTUAL_HOST and VIRTUAL_HOST_MULTIPORTS variables used by containers, controlled by VIRTUAL_HOST_ENV_PREFIX environment variable set on the nginx-proxy. E.g. set VIRTUAL_HOST_ENV_PREFIX=VIRTUAL_HOST_MY_NETWORK, and only containers with VIRTUAL_HOST_MY_NETWORK=something will be managed by that nginx-proxy instance.
p12tic
changed the title
p12tic
changed the title
Contributor
Author
|
Turns out #2659 implements support for similar use case by using a different approach. |
Contributor
Author
|
Closing because nginx-proxy/docker-gen#276 will implement the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if it makes sense nginx-proxy to support a feature like this, but I already have a proof of concept and instead of opening an issue a PR was created straight away. Let me know if the feature itself makes sense and I will rewrite PR in any way needed.
This feature is useful in cases there are multiple networks to be managed with nginx-proxy on the same host. For example, a public network and a network that can only be reached through a VPN.
This commit makes it possible to use multiple instances of nginx-proxy in such use cases. Each instance has a separate "namespace" of VIRTUAL_HOST and VIRTUAL_HOST_MULTIPORTS variables used by containers, controlled by VIRTUAL_HOST_ENV_PREFIX environment variable set on the nginx-proxy. E.g. set VIRTUAL_HOST_ENV_PREFIX=VIRTUAL_HOST_MY_NETWORK, and only containers with VIRTUAL_HOST_MY_NETWORK=something will be managed by that nginx-proxy instance.