Add container filtering feature#2659
Closed
eorea wants to merge 3 commits into
Closed
Conversation
Contributor
|
#2660 also implements support for a similar use case by using a different approach. The VIRTUAL_HOST and VIRTUAL_HOST_MULTIPORTS environment variables are made configurable for each of the different nginx-proxy instances. I have no opinion on which approach is better. |
Author
|
FYI, seems that docker_gen will be also implementing filtering using labels by end of month nginx-proxy/docker-gen#276 this will achieve the exact same thing as this PR, and CONTAINER_FILTER_LABEL variable could be used to filter straight from docker_gen instead of doing it at the templating |
Contributor
|
Great, seems my PR is not needed then. |
Member
|
Closing, since this is now handled by docker-gen directly using the Documentation is here #2667 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows the filtering of containers with an specific label, those containers that have the filtering label defined would be the ones that would become available for processing.
The feature is fully backwards compatible, if no filtering label is provided via CONTAINER_FILTER_LABEL environment variable all containers in the docker host will be considered for processing.
4 test scenarios has been included, 2 to validate new behavior in both single o multiple instance setups, and 2 to validate the backwards compatible scenarios with the feature not enabled also in both single o multiple instance setups.
The scenarios identified where using this filtering is helpful are: