Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reject SSL handshake rather than using empty certificate #2520

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: reject SSL handshake rather than using empty certificate #2520

merged 1 commit into from
Oct 3, 2024

Conversation

buchdag
Copy link
Member

@buchdag buchdag commented Oct 3, 2024

This PR fixes #2287

This might have worked at some point to reject SSL connections but clearly does not anymore ( you can't pass empty data to ssl_certificate / ssl_certificate_key, as seen in #2287 ):

ssl_ciphers aNULL;
set $empty "";
ssl_certificate data:$empty;
ssl_certificate_key data:$empty;
if ($https) {
    return 444;
}

The correct way to do this is by using ssl_reject_handshake.

@buchdag buchdag added the type/fix PR for a bug fix label Oct 3, 2024
@buchdag buchdag merged commit 6948880 into main Oct 3, 2024
4 checks passed
@buchdag buchdag deleted the reject-handshake branch October 3, 2024 08:23
@buchdag buchdag mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/fix PR for a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot load certificate, Expecting: TRUSTED CERTIFICATE
1 participant
@buchdag