Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test if nginx-proxy-builder can be build successfully #2435

Merged
merged 3 commits into from
May 3, 2024

Conversation

SchoNie
Copy link
Contributor

@SchoNie SchoNie commented May 3, 2024

Tests for: Dockerfile-nginx-proxy-tester

Test if we can build and run (and verify pytest output) the nginx-proxy-tester image. As the Dockerfile installs quite some dependencies and there is no place we currently check if it works.
If things break by future change we should see in CI.

Copy link
Member

@buchdag buchdag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code style consistency suggestions.

@buchdag buchdag added the type/test PR that add missing tests or correct existing tests label May 3, 2024
Commited code style consistency suggestions.

Co-authored-by: Nicolas Duchon <[email protected]>
buchdag
buchdag previously approved these changes May 3, 2024
@buchdag buchdag merged commit b4bceac into nginx-proxy:main May 3, 2024
2 checks passed
@SchoNie SchoNie deleted the nginx-proxy-tester branch May 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/test PR that add missing tests or correct existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants