Skip to content

Various code health chores #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
buchdag merged 11 commits into from
Jan 17, 2023
Merged

Various code health chores #2127

buchdag merged 11 commits into from
Jan 17, 2023

Conversation

@rhansen
Copy link
Collaborator

@rhansen rhansen commented Jan 1, 2023

No behavior changes, just cleanups.

This was referenced Jan 1, 2023
Open
Merged
buchdag
buchdag requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@buchdag buchdag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for that last commit, I don't want to spark an endless debate but I find two space tabs make code harder to read, especially on GitHub.

@rhansen
Copy link
Collaborator Author

rhansen commented Jan 9, 2023

LGTM except for that last commit, I don't want to spark an endless debate but I find two space tabs make code harder to read, especially on GitHub.

OK, I'll do 4 spaces. Or would you prefer something else?

@rhansen
Copy link
Collaborator Author

rhansen commented Jan 9, 2023 •
edited
Loading

OK, I'll do 4 spaces.

Done.

I also pushed some new commits:

  • Re-wrap long template comments to keep those lines under 80 columns long. (Unfortunately golang templates do not support line continuations inside {{...}} except for comments.)
  • Move global variable values into a $globals dict to make it easier for future commits to pass the values to templates.

@rhansen rhansen requested a review from buchdag January 11, 2023 19:18
@rhansen rhansen force-pushed the chores branch 2 times, most recently from 545763e to 0034bb1 Compare January 14, 2023 07:40
rhansen added 11 commits January 17, 2023 00:42
@buchdag buchdag merged commit 017a731 into nginx-proxy:main Jan 17, 2023
@rhansen rhansen deleted the chores branch January 17, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buchdag buchdag buchdag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhansen @buchdag