Add support for custom external HTTP/HTTPS ports #1353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to choose arbitrary ports for HTTP and HTTPS instead of 80 and 443.
While it does not change anything in the way ports can be mapped to host using native Docker capabilities, it fixes the "invalid"
X-Forwarded-Portwhen the port on which nginx listens to is different from the one it is mapped - and accessed by clients - on the host.Typical usage in docker-compose (here with the custom ports
1080and10443):I'm open to suggestions.
Thanks for your amazing work on this image, it helps a lot.
Regards,