Skip to content

Filter containers to notify#549

Closed
tarasov65536 wants to merge 3 commits into
nginx-proxy:mainfrom
tarasov65536:notify-filter
Closed

Filter containers to notify#549
tarasov65536 wants to merge 3 commits into
nginx-proxy:mainfrom
tarasov65536:notify-filter

Conversation

@tarasov65536

Copy link
Copy Markdown
Contributor

This PR gives ability to specify set of filters to containers query when new generated file arrived.

It is kinda similar to #311 but with better implementation from architectural point of view.

It introduces new command line argument -notify-filter that adds filter in list of filters to query containers that should be notified when generated file changed. Argument format as in docker api

For example:

docker-gen -notify-filter name=foo -notify-filter label=bar=baz ...

adds two filters to containers query.

Signal code still defined by argument -notify-signal.

@josegonzalez

Copy link
Copy Markdown
Contributor

This probably needs a test in order to get merged.

@tarasov65536

Copy link
Copy Markdown
Contributor Author

@josegonzalez, what kind of test it needs? Can't find anything similar.

@buchdag

buchdag commented May 16, 2024

Copy link
Copy Markdown
Member

Superseded by #619

@buchdag buchdag closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants