Skip to content

Switch to slog #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lucacome merged 1 commit into from
Sep 11, 2024
Merged

Switch to slog #841

lucacome merged 1 commit into from
Sep 11, 2024

Conversation

@lucacome
Copy link
Contributor

@lucacome lucacome commented Sep 10, 2024

Proposed changes

After prometheus/exporter-toolkit#240 we can switch to using slog.

Closes #484

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@lucacome lucacome requested a review from a team as a code owner September 10, 2024 00:25
@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements dependencies Pull requests that update a dependency file labels Sep 10, 2024
@codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 3.90%. Comparing base (46f7fbf) to head (c7e6d4d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter.go 0.00% 15 Missing ⚠️
collector/nginx_plus.go 0.00% 9 Missing ⚠️
collector/nginx.go 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #841   +/-   ##
=====================================
  Coverage   3.90%   3.90%           
=====================================
  Files          5       5           
  Lines       1307    1307           
=====================================
  Hits          51      51           
  Misses      1256    1256

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lucacome lucacome self-assigned this Sep 10, 2024
@lucacome lucacome requested review from a team and kate-osborn September 11, 2024 16:32
@kate-osborn
Copy link

kate-osborn commented Sep 11, 2024

To achieve consistency across all NGF logs would we need to implement slog.Handler and pass that to the slog.Logger?

@lucacome
Copy link
Contributor Author

lucacome commented Sep 11, 2024

logr has FromSlogHandler and ToSlogHandler that I think can be used for this

@kate-osborn
Copy link

kate-osborn commented Sep 11, 2024

logr has FromSlogHandler and ToSlogHandler that I think can be used for this

Awesome. Do you mind opening an issue in NGF backlog for that work?

@lucacome lucacome merged commit 5c317a6 into main Sep 11, 2024
@lucacome lucacome deleted the enh/slog branch September 11, 2024 23:35
@github-actions github-actions bot mentioned this pull request Dec 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjngx jjngx jjngx approved these changes

+1 more reviewer

@kate-osborn kate-osborn kate-osborn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lucacome lucacome

Labels

dependencies Pull requests that update a dependency file enhancement Pull requests for new features/feature enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support logger injection

4 participants

@lucacome @kate-osborn @jjngx