Skip to content

Conversation

@Dean-Coakley
Copy link
Contributor

Proposed changes

  • Fix typos in docs
  • Add apiVersion metadata to chart for helm3 compatibility

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

* Fix typos in docs
* Add apiVersion metadata to chart for helm3 compatibility
@Dean-Coakley Dean-Coakley added the documentation Pull requests/issues for documentation label Jan 13, 2020
@Dean-Coakley Dean-Coakley self-assigned this Jan 13, 2020
@pleshakov pleshakov mentioned this pull request Jan 13, 2020
1 task
Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dean-Coakley thx. please see my suggestion

Copy link
Contributor

@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Dean-Coakley Dean-Coakley merged commit 6ccbd5d into release-1.6 Jan 14, 2020
@Dean-Coakley Dean-Coakley deleted the update-helm-docs branch January 14, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants