Skip to content

Remove extra double quote in variable assignment #8067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdabelf5 merged 3 commits into from
Jul 23, 2025
Merged

Remove extra double quote in variable assignment #8067

pdabelf5 merged 3 commits into from
Jul 23, 2025

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jul 23, 2025 •
edited
Loading

Proposed changes

Remove extra double quote in variable assignment

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner July 23, 2025 11:00
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jul 23, 2025
vepatel
vepatel previously approved these changes Jul 23, 2025
View reviewed changes
@pdabelf5 pdabelf5 enabled auto-merge (squash) July 23, 2025 13:03
@codecov
Copy link

codecov bot commented Jul 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.07%. Comparing base (c315a25) to head (4ec0dbe).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8067      +/-   ##
==========================================
- Coverage   53.09%   53.07%   -0.03%     
==========================================
  Files          90       90              
  Lines       21770    21772       +2     
==========================================
- Hits        11559    11555       -4     
- Misses       9736     9740       +4     
- Partials      475      477       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdabelf5 pdabelf5 merged commit 82f3d30 into main Jul 23, 2025
34 checks passed
@pdabelf5 pdabelf5 deleted the chore/image-promotion-typo branch July 23, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees

No one assigned

Labels

chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pdabelf5 @vepatel @AlexFenlon