Skip to content

Conversation

@ADubhlaoich
Copy link
Member

@ADubhlaoich ADubhlaoich commented Apr 28, 2025

Proposed changes

This commit replaces all production URLS in the Release page for NGINX Ingress Controller with relative Hugo references instead. This improves the consistency of URLs for the documentation set, and allows for Hugo to handle broken link references.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit replaces all production URLS in the Release page for NGINX
Ingress Controller with relative Hugo references instead. This improves
the consistency of URLs for the documentation set, and allows for Hugo
to handle broken link references.
@ADubhlaoich ADubhlaoich requested review from a team as code owners April 28, 2025 16:04
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 28, 2025
@github-actions
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7708/

vepatel
vepatel previously approved these changes Apr 28, 2025
@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Apr 28, 2025
@vepatel vepatel self-requested a review April 29, 2025 10:57
Co-authored-by: Gabor Javorszky <[email protected]>
Signed-off-by: Alan Dooley <[email protected]>
@ADubhlaoich ADubhlaoich merged commit 3065916 into main Apr 29, 2025
30 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/fix-release-links branch April 29, 2025 14:02
nginx-bot pushed a commit that referenced this pull request Apr 29, 2025
This commit replaces all production URLs in the Release page for NGINX
Ingress Controller with relative Hugo references instead. This improves
the consistency of URLs for the documentation set, and allows for Hugo
to handle broken link references.

Co-authored-by: Gabor Javorszky <[email protected]>
Co-authored-by: Paul Abel <[email protected]>
Co-authored-by: Venktesh Shivam Patel <[email protected]>
@AlexFenlon AlexFenlon removed the needs cherry pick Cherry pick this PR into a release branch label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants