Skip to content

Use pod labels as headless selector labels #7654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdabelf5 merged 2 commits into from
Apr 15, 2025
Merged

Use pod labels as headless selector labels #7654

pdabelf5 merged 2 commits into from
Apr 15, 2025

Conversation

@nginx-bot
Copy link
Contributor

@nginx-bot nginx-bot commented Apr 15, 2025

Proposed changes

Update the headless service generation for zone-sync to use the pods labels as the selector labels for the headless service.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner April 15, 2025 13:49
@nginx-bot nginx-bot added go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart needs cherry pick Cherry pick this PR into a release branch labels Apr 15, 2025
@codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-5.0@64fda16). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/nginx-ingress/main.go 0.00% 3 Missing ⚠️
internal/k8s/service.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##             release-5.0    #7654   +/-   ##
==============================================
  Coverage               ?   52.17%           
==============================================
  Files                  ?       89           
  Lines                  ?    21265           
  Branches               ?        0           
==============================================
  Hits                   ?    11096           
  Misses                 ?     9705           
  Partials               ?      464

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdabelf5 pdabelf5 merged commit 78e3e17 into release-5.0 Apr 15, 2025
74 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-5.0-1169c7f8d8f0e4242e8c2f160cce463c8b3c50a9 branch April 15, 2025 15:04
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart needs cherry pick Cherry pick this PR into a release branch labels Apr 15, 2025
@pdabelf5 pdabelf5 changed the title [cherry-pick] Use pod labels as headless selector labels Use pod labels as headless selector labels Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees

No one assigned

Labels

enhancement Pull requests for new features/feature enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nginx-bot @vepatel @AlexFenlon @pdabelf5