Skip to content

Use pod labels as headless selector labels #7651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdabelf5 merged 2 commits into from
Apr 15, 2025
Merged

Use pod labels as headless selector labels #7651

pdabelf5 merged 2 commits into from
Apr 15, 2025

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Apr 15, 2025 •
edited
Loading

Proposed changes

Update the headless service generation for zone-sync to use the pods labels as the selector labels for the headless service.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner April 15, 2025 12:05
@github-actions github-actions bot added go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Apr 15, 2025
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.17%. Comparing base (ec4d6b1) to head (0a24450).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/main.go 0.00% 3 Missing ⚠️
internal/k8s/service.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7651   +/-   ##
=======================================
  Coverage   52.17%   52.17%           
=======================================
  Files          89       89           
  Lines       21269    21265    -4     
=======================================
- Hits        11098    11096    -2     
+ Misses       9707     9705    -2     
  Partials      464      464

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdabelf5 pdabelf5 added the needs cherry pick Cherry pick this PR into a release branch label Apr 15, 2025
@pdabelf5 pdabelf5 merged commit 1169c7f into main Apr 15, 2025
30 checks passed
@pdabelf5 pdabelf5 deleted the headless-selector-label branch April 15, 2025 13:49
nginx-bot pushed a commit that referenced this pull request Apr 15, 2025
@pdabelf5 @web-flow
Use pod labels as headless selector labels (#7651)
fc2468a
pdabelf5 added a commit that referenced this pull request Apr 15, 2025
@nginx-bot @pdabelf5
[cherry-pick] Use pod labels as headless selector labels (#7654)
78e3e17 
Use pod labels as headless selector labels (#7651)

Co-authored-by: Paul Abel <[email protected]>
@AlexFenlon AlexFenlon added bug An issue reporting a potential bug and removed go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart needs cherry pick Cherry pick this PR into a release branch labels Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javorszky javorszky javorszky approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees

No one assigned

Labels

bug An issue reporting a potential bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pdabelf5 @javorszky @haywoodsh @vepatel @AlexFenlon