Skip to content

Update zone-sync headless service selector label #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexFenlon merged 7 commits into from
Mar 4, 2025
Merged

Update zone-sync headless service selector label #7445

AlexFenlon merged 7 commits into from
Mar 4, 2025

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 3, 2025 •
edited
Loading

Proposed changes

Fix selector labels for zonesync headless service

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner March 3, 2025 15:30
@github-actions github-actions bot added go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Mar 3, 2025
@AlexFenlon AlexFenlon linked an issue Mar 3, 2025 that may be closed by this pull request
[Bug]: Fix zone-sync headless service labels #7446
Closed
@codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.77%. Comparing base (9a0a3f7) to head (f2e526a).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
cmd/nginx-ingress/main.go 0.00% 1 Missing ⚠️
internal/k8s/service.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7445   +/-   ##
=======================================
  Coverage   52.76%   52.77%           
=======================================
  Files          89       89           
  Lines       21267    21267           
=======================================
+ Hits        11221    11223    +2     
+ Misses       9582     9580    -2     
  Partials      464      464

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vepatel
vepatel reviewed Mar 3, 2025
View reviewed changes
@AlexFenlon AlexFenlon merged commit 7ed593f into main Mar 4, 2025
81 checks passed
@AlexFenlon AlexFenlon deleted the zone-synx-match-label branch March 4, 2025 10:35
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Apr 4, 2025
@pdabelf5 pdabelf5 changed the title update zone-sync headless service selector label Update zone-sync headless service selector label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@vepatel vepatel vepatel approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Pull requests for new features/feature enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Fix zone-sync headless service labels

5 participants

@pdabelf5 @vepatel @AlexFenlon @jjngx