Add tracking.info and copy into plus images #7400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Closes #7360 * adds a `dependencies/tracking.info.default` file that is mounted into the docker images that include nginx plus * file contains attribution to nic * dockerfile also has comments explaining the inclusion This is potentially a stopgap solution until we have time to look at startup order.
javorszky
force-pushed
the
fix/7360-multiple-usage-requests
branch
from
fecef1c to
bdb1e83
Compare
pdabelf5
reviewed
Feb 24, 2025
Collaborator
pdabelf5
left a comment
pdabelf5
left a comment
There was a problem hiding this comment.
if the file was add in the nginx-files stage, it could be copied in each plus stage without needing an additional layer
Contributor
Author
Moved this in a new commit. I'll squash these together before merging if all is good 🙂 |
pdabelf5
reviewed
Feb 24, 2025
pdabelf5
approved these changes
Feb 25, 2025
jjngx
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7360
Proposed changes
dependencies/tracking.info.defaultfile that is mounted into the docker images that include nginx plusThis is potentially a stopgap solution until we have time to look at startup order.
Checklist
Before creating a PR, run through this checklist and mark each as complete.