Skip to content

Bump Go version to 1.23.5 #7160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jjngx merged 3 commits into from
Jan 20, 2025
Merged

Bump Go version to 1.23.5 #7160

jjngx merged 3 commits into from
Jan 20, 2025

Conversation

@jjngx
Copy link
Contributor

@jjngx jjngx commented Jan 20, 2025

Proposed changes

This PR brings Go version 1.23.5. The release addresses following CVEs and other fixes:

net/http: sensitive headers incorrectly sent after cross-domain redirect [CVE-2024-45336]
crypto/x509: usage of IPv6 zone IDs can bypass URI name constraints [CVE-2024-45341]

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner January 20, 2025 09:18
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 20, 2025
@codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.71%. Comparing base (c449170) to head (07e4936).
Report is 173 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7160      +/-   ##
==========================================
- Coverage   52.73%   52.71%   -0.02%     
==========================================
  Files          89       89              
  Lines       20843    20843              
==========================================
- Hits        10992    10988       -4     
- Misses       9394     9396       +2     
- Partials      457      459       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Jan 20, 2025
@jjngx jjngx merged commit 2eb223f into main Jan 20, 2025
73 checks passed
@jjngx jjngx deleted the chore/goversion branch January 20, 2025 11:24
nginx-bot pushed a commit that referenced this pull request Jan 20, 2025
@jjngx @web-flow
Bump Go version to 1.23.5 (#7160)
89c96ef
pdabelf5 pushed a commit that referenced this pull request Jan 30, 2025
@jjngx @pdabelf5
Bump Go version to 1.23.5 (#7160)
f28b1ea
@pdabelf5 pdabelf5 added skip changelog Pull requests that don't need to be added to the changelog and removed dependencies Pull requests that update a dependency file go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees

No one assigned

Labels

skip changelog Pull requests that don't need to be added to the changelog

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jjngx @vepatel @AlexFenlon @pdabelf5