Skip to content

Avoid floating semi-colon on rate-limiting newline #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdabelf5 merged 2 commits into from
Jan 20, 2025
Merged

Avoid floating semi-colon on rate-limiting newline #7156

pdabelf5 merged 2 commits into from
Jan 20, 2025

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 17, 2025 •
edited
Loading

Proposed changes

Tidy the newlines in the ratelimiting templates

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 17, 2025 14:46
@codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.74%. Comparing base (c449170) to head (7e8b6b7).
Report is 165 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7156   +/-   ##
=======================================
  Coverage   52.73%   52.74%           
=======================================
  Files          89       89           
  Lines       20843    20843           
=======================================
+ Hits        10992    10994    +2     
+ Misses       9394     9392    -2     
  Partials      457      457

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdabelf5 pdabelf5 enabled auto-merge (squash) January 17, 2025 16:19
@pdabelf5 pdabelf5 merged commit babe3fe into main Jan 20, 2025
74 checks passed
@pdabelf5 pdabelf5 deleted the ratelimit-template-tidy branch January 20, 2025 10:09
pdabelf5 added a commit that referenced this pull request Jan 30, 2025
@pdabelf5
avoid floating semi-colon on rate-limiting newline (#7156)
97cbd9e
@pdabelf5 pdabelf5 changed the title avoid floating semi-colon on rate-limiting newline Avoid floating semi-colon on rate-limiting newline Apr 4, 2025
@pdabelf5 pdabelf5 added the chore Pull requests for routine tasks label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pdabelf5 @vepatel @AlexFenlon @jjngx