Skip to content

Conversation

@nginx-aoife
Copy link
Contributor

Proposed changes

Fix broken links to NIM App Protect Docs.
NIM doc reorganisation and recent clearing of Azure cache is the likely cause of this broken links.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Fix link to NIM app-protect docs

Signed-off-by: nginx-aoife <[email protected]>
Fix link to NIM App-protect docs

Signed-off-by: nginx-aoife <[email protected]>
@nginx-aoife nginx-aoife added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Jan 14, 2025
@nginx-aoife nginx-aoife requested review from a team as code owners January 14, 2025 13:57
@github-actions
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7129/

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JTorreG JTorreG merged commit 3dc84ba into main Jan 14, 2025
30 checks passed
@JTorreG JTorreG deleted the bug-fix-url branch January 14, 2025 14:06
nginx-bot pushed a commit that referenced this pull request Jan 14, 2025
* Update releases.md

Fix link to NIM app-protect docs

Signed-off-by: nginx-aoife <[email protected]>

* Update compile-waf-policies.md

Fix link to NIM App-protect docs

Signed-off-by: nginx-aoife <[email protected]>

---------

Signed-off-by: nginx-aoife <[email protected]>
nginx-aoife added a commit that referenced this pull request Jan 14, 2025
Docs: Fix links to NIM App-protect docs (#7129)

* Update releases.md

Fix link to NIM app-protect docs



* Update compile-waf-policies.md

Fix link to NIM App-protect docs



---------

Signed-off-by: nginx-aoife <[email protected]>
Co-authored-by: nginx-aoife <[email protected]>
pdabelf5 pushed a commit that referenced this pull request Jan 30, 2025
* Update releases.md

Fix link to NIM app-protect docs

Signed-off-by: nginx-aoife <[email protected]>

* Update compile-waf-policies.md

Fix link to NIM App-protect docs

Signed-off-by: nginx-aoife <[email protected]>

---------

Signed-off-by: nginx-aoife <[email protected]>
@pdabelf5 pdabelf5 changed the title Docs: Fix links to NIM App-protect docs Fix links to NIM App-protect docs Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants