Skip to content

Fix broken link in example for nginx plus license #7106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexFenlon merged 3 commits into from
Jan 13, 2025
Merged

Fix broken link in example for nginx plus license #7106

AlexFenlon merged 3 commits into from
Jan 13, 2025

Conversation

@AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Jan 10, 2025

Proposed changes

fix broken link in example for nginx plus license that we missed while doing v4.0.0 docs & example

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner January 10, 2025 12:32
@github-actions github-actions bot added bug An issue reporting a potential bug documentation Pull requests/issues for documentation labels Jan 10, 2025
@AlexFenlon AlexFenlon added the needs cherry pick Cherry pick this PR into a release branch label Jan 10, 2025
@AlexFenlon AlexFenlon merged commit 4284ecf into main Jan 13, 2025
28 checks passed
@AlexFenlon AlexFenlon deleted the fix/nginx-plus-example-link branch January 13, 2025 09:58
nginx-bot pushed a commit that referenced this pull request Jan 13, 2025
@AlexFenlon @web-flow
fix broken link in example for nginx plus license (#7106)
bb570be
pdabelf5 pushed a commit that referenced this pull request Jan 30, 2025
@AlexFenlon @pdabelf5
fix broken link in example for nginx plus license (#7106)
d62fdca
@pdabelf5 pdabelf5 removed the bug An issue reporting a potential bug label Feb 6, 2025
@pdabelf5 pdabelf5 changed the title fix broken link in example for nginx plus license Fix broken link in example for nginx plus license Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlexFenlon @vepatel @jjngx @pdabelf5