Skip to content

Refactor handleSpecialSecretUpdate #6875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdabelf5 merged 4 commits into from
Nov 28, 2024
Merged

Refactor handleSpecialSecretUpdate #6875

pdabelf5 merged 4 commits into from
Nov 28, 2024

Conversation

@j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Nov 27, 2024

Proposed changes

refactor special secret validation for easier extensibility

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner November 27, 2024 14:49
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 27, 2024
@codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.78571% with 55 lines in your changes missing coverage. Please review.

Project coverage is 53.17%. Comparing base (8b8fc52) to head (0884769).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 0.00% 30 Missing ⚠️
internal/configs/configurator.go 3.84% 18 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6875      +/-   ##
==========================================
- Coverage   53.24%   53.17%   -0.07%     
==========================================
  Files          88       88              
  Lines       20363    20380      +17     
==========================================
- Hits        10842    10838       -4     
- Misses       9078     9097      +19     
- Partials      443      445       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 force-pushed the chore/refactor-special-secret-handling branch from 76dbf63 to 3d30f6a Compare November 28, 2024 11:47
@pdabelf5 pdabelf5 enabled auto-merge (squash) November 28, 2024 12:18
@pdabelf5 pdabelf5 merged commit ba34c0e into main Nov 28, 2024
80 checks passed
@pdabelf5 pdabelf5 deleted the chore/refactor-special-secret-handling branch November 28, 2024 12:23
@pdabelf5 pdabelf5 changed the title refactor handleSpecialSecretUpdate Refactor handleSpecialSecretUpdate Dec 16, 2024
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@j1m-ryan @jjngx @pdabelf5