Skip to content

Refactor namespace/name logic #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdabelf5 merged 4 commits into from
Nov 27, 2024
Merged

Refactor namespace/name logic #6871

pdabelf5 merged 4 commits into from
Nov 27, 2024

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 27, 2024 •
edited
Loading

Proposed changes

Avoid doing the same thing more than once

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 27, 2024 11:29
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 27, 2024
@codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.25%. Comparing base (729570c) to head (8324d0f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 40.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6871      +/-   ##
==========================================
+ Coverage   53.23%   53.25%   +0.02%     
==========================================
  Files          88       88              
  Lines       20354    20356       +2     
==========================================
+ Hits        10835    10841       +6     
+ Misses       9074     9072       -2     
+ Partials      445      443       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vepatel
vepatel reviewed Nov 27, 2024
View reviewed changes
@pdabelf5 pdabelf5 enabled auto-merge (squash) November 27, 2024 15:24
@pdabelf5 pdabelf5 merged commit 2767500 into main Nov 27, 2024
78 checks passed
@pdabelf5 pdabelf5 deleted the refactor-special-secret-name branch November 27, 2024 15:43
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
@pdabelf5 pdabelf5 changed the title refactor namespace/name logic Refactor namespace/name logic Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

+1 more reviewer

@j1m-ryan j1m-ryan j1m-ryan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pdabelf5 @j1m-ryan @vepatel @AlexFenlon