Skip to content

Build UBI s390x nginx package for OSS images #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pdabelf5 merged 1 commit into from
Nov 22, 2024
Merged

Build UBI s390x nginx package for OSS images #6847

pdabelf5 merged 1 commit into from
Nov 22, 2024

Conversation

@nginx-bot
Copy link
Contributor

@nginx-bot nginx-bot commented Nov 22, 2024

Proposed changes

Similar to PPC64LE architectures, we now need to build s390x packages for UBI images.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner November 22, 2024 10:15
@nginx-bot nginx-bot added chore Pull requests for routine tasks docker Pull requests that update Docker code github_actions Pull requests that update Github_actions code needs cherry pick Cherry pick this PR into a release branch labels Nov 22, 2024
@vepatel vepatel changed the title [cherry-pick] build UBI s390x nginx package for OSS images build UBI s390x nginx package for OSS images Nov 22, 2024
@vepatel vepatel removed the needs cherry pick Cherry pick this PR into a release branch label Nov 22, 2024
@codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-3.7@eef3176). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff               @@
##             release-3.7    #6847   +/-   ##
==============================================
  Coverage               ?   52.97%           
==============================================
  Files                  ?       85           
  Lines                  ?    19764           
  Branches               ?        0           
==============================================
  Hits                   ?    10469           
  Misses                 ?     8887           
  Partials               ?      408

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@pdabelf5 pdabelf5 enabled auto-merge (squash) November 22, 2024 10:37
@pdabelf5 pdabelf5 merged commit acad002 into release-3.7 Nov 22, 2024
72 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-3.7-cab70d737a65d9932b9e41efc3614303307f8c42 branch November 22, 2024 10:50
@pdabelf5 pdabelf5 removed github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code labels Nov 25, 2024
@pdabelf5 pdabelf5 changed the title build UBI s390x nginx package for OSS images Build UBI s390x nginx package for OSS images Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nginx-bot @vepatel @AlexFenlon @jjngx @pdabelf5