Skip to content

Add plus mgmt deployment context process #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexFenlon merged 11 commits into from
Nov 5, 2024
Merged

Add plus mgmt deployment context process #6309

AlexFenlon merged 11 commits into from
Nov 5, 2024

Conversation

@j1m-ryan
Copy link

@j1m-ryan j1m-ryan commented Aug 29, 2024 •
edited by pdabelf5
Loading

Proposed changes

Adds the license reporting writing process

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the go Pull requests that update Go code label Aug 29, 2024
@codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 43.10345% with 66 lines in your changes missing coverage. Please review.

Project coverage is 53.38%. Comparing base (b078841) to head (ad2b294).
Report is 108 commits behind head on main.

Files with missing lines Patch % Lines
internal/license_reporting/license_reporting.go 41.86% 23 Missing and 2 partials ⚠️
internal/nginx/manager.go 0.00% 22 Missing ⚠️
...nternal/common_cluster_info/common_cluster_info.go 72.50% 8 Missing and 3 partials ⚠️
cmd/nginx-ingress/main.go 0.00% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6309      +/-   ##
==========================================
- Coverage   53.47%   53.38%   -0.09%     
==========================================
  Files          87       89       +2     
  Lines       20120    20195      +75     
==========================================
+ Hits        10759    10781      +22     
- Misses       8926     8977      +51     
- Partials      435      437       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vepatel
vepatel reviewed Sep 2, 2024
View reviewed changes
shaun-nx
shaun-nx reviewed Sep 2, 2024
View reviewed changes
@j1m-ryan j1m-ryan marked this pull request as ready for review September 4, 2024 12:35
@j1m-ryan j1m-ryan requested a review from a team as a code owner September 4, 2024 12:35
@j1m-ryan j1m-ryan marked this pull request as draft September 9, 2024 08:39
@shaun-nx shaun-nx linked an issue Sep 18, 2024 that may be closed by this pull request
Write report marker #5385
Closed
shaun-nx
shaun-nx reviewed Sep 18, 2024
View reviewed changes
shaun-nx
shaun-nx reviewed Sep 23, 2024
View reviewed changes
@j1m-ryan j1m-ryan closed this Oct 9, 2024
@nginx nginx deleted a comment from j1m-ryan Oct 9, 2024
@j1m-ryan j1m-ryan reopened this Oct 31, 2024
@AlexFenlon AlexFenlon marked this pull request as ready for review November 5, 2024 15:23
@AlexFenlon AlexFenlon requested review from jjngx and shaun-nx November 5, 2024 15:23
@AlexFenlon AlexFenlon merged commit bfcbf4c into main Nov 5, 2024
81 checks passed
@AlexFenlon AlexFenlon deleted the chore/add-report-marker branch November 5, 2024 17:15
@pdabelf5 pdabelf5 changed the title add license reporting process Add plus mgmt deployment context process Dec 16, 2024
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vepatel vepatel vepatel left review comments

@AlexFenlon AlexFenlon AlexFenlon left review comments

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

+1 more reviewer

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Write report marker

7 participants

@j1m-ryan @vepatel @AlexFenlon @jjngx @shaun-nx @pdabelf5