Add NTLM support to VirtualServer and VirtualServerRoute upstreams #1908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
soneillf5
reviewed
Aug 27, 2021
| {{ end }} | ||
| {{ end }} | ||
|
|
||
| {{ if $u.NTLM }}ntlm;{{ end }} |
soneillf5
approved these changes
Aug 27, 2021
pleshakov
reviewed
Aug 27, 2021
Contributor
pleshakov
left a comment
pleshakov
left a comment
There was a problem hiding this comment.
Hi @ciarams87 Looks good, just a few suggestions
docs/content/configuration/virtualserver-and-virtualserverroute-resources.md
Outdated
Show resolved
Hide resolved
…e-resources.md Co-authored-by: Michael Pleshakov <[email protected]>
Co-authored-by: Michael Pleshakov <[email protected]>
pleshakov
changed the title
pleshakov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support setting NTLM authentication in an upstream. See http://nginx.org/en/docs/http/ngx_http_upstream_module.html#ntlm
Closes #1896
Checklist
Before creating a PR, run through this checklist and mark each as complete.