Support match in TransportServer health checks #1633
Conversation
github-actions
bot
added
documentation
soneillf5
left a comment
soneillf5
left a comment
There was a problem hiding this comment.
Can you add a test to the python test suite that confirms the functionality of this change?
soneillf5
left a comment
soneillf5
left a comment
There was a problem hiding this comment.
I need to leave a comment to request changes.
| assert len(endpoints) is 3 | ||
|
|
||
| @pytest.mark.skip_for_nginx_oss | ||
| def test_tcp_passing_healthcheck_with_match( |
There was a problem hiding this comment.
@pleshakov these tests also looks like a decent candidates to use parameterization to pass various ts/cases, see: https://github.com/nginxinc/kubernetes-ingress/blob/master/tests/suite/test_ingress_mtls.py#L82
There was a problem hiding this comment.
makes sense. let me know about this https://github.com/nginxinc/kubernetes-ingress/pull/1633/files#r643518158
There was a problem hiding this comment.
Yeah that's fine for now that its added and working but we don't need to verify all the attribs as nginx plus is doing lb and the UI is provided by the same.
|
|
||
| func TestGenerateTransportServerHealthChecks(t *testing.T) { | ||
| upstreamName := "dns-tcp" | ||
| generatedUpsteamName := "ts_namespace_name_dns-tcp" |
There was a problem hiding this comment.
is there one for dns-udp too?
pleshakov
force-pushed
the
feature/ts-hc-match
branch
from
699597d to
123003b
Compare
Proposed changes
Support match in TransportServer health checks
Based on the original work from @soneillf5