Skip to content

Conversation

@Dean-Coakley
Copy link
Contributor

Proposed changes

  • Uninstall instructions leave trailing Custom Resource Definitions behind. This change instructs how they can be removed and warns the reader about destruction nature of CRD removal.
  • Correct ClusterRole/CRBinding step.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley added the documentation Pull requests/issues for documentation label Jan 22, 2021
@Dean-Coakley Dean-Coakley self-assigned this Jan 22, 2021
```
$ kubectl delete namespace nginx-ingress
```
2. Delete the ClusterRole and ClusterRoleBinding created in that step:
Copy link
Contributor Author

@Dean-Coakley Dean-Coakley Jan 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ClusterRole and ClusterRoleBinding were not created in the previous step. I suggest removal of that part of this step.

@Dean-Coakley Dean-Coakley merged commit 49b296d into master Feb 3, 2021
@Dean-Coakley Dean-Coakley deleted the update-uninstall-docs branch February 3, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants