Add OIDC policy #1304
Merged
Add OIDC policy #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucacome
requested review from
Dean-Coakley,
LorcanMcVeigh,
mikestephen and
pleshakov
mikestephen
reviewed
Jan 14, 2021
LorcanMcVeigh
approved these changes
Jan 14, 2021
Dean-Coakley
approved these changes
Jan 14, 2021
Co-authored-by: Dean Coakley <[email protected]>
pleshakov
reviewed
Jan 14, 2021
| return res | ||
| } | ||
|
|
||
| func (p *policiesCfg) addOIDCConfig( |
Contributor
There was a problem hiding this comment.
could we add more test cases for addOIDCConfig ? from looking at the coverage, there are no cases for the edge cases
Contributor
|
@lucacome |
pleshakov
approved these changes
Jan 15, 2021
Co-authored-by: Michael Pleshakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add OIDC policy
TODO: