Add stricter validation for some ingress annotations #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikestephen
requested review from
Dean-Coakley,
LorcanMcVeigh,
lucacome,
pleshakov and
vepatel
pleshakov
approved these changes
Dec 17, 2020
| var proxyBuffersRegexp = regexp.MustCompile(`^\d+ \d+[kKmM]?$`) | ||
|
|
||
| // ParseProxyBuffersSpec ensures that the string value is a valid proxy buffer spec | ||
| func ParseProxyBuffersSpec(s string) (string, error) { |
Contributor
There was a problem hiding this comment.
would it help to have a unit test for this func?
Author
There was a problem hiding this comment.
Thanks, I'd forgotten, added one now.
6 tasks
Dean-Coakley
approved these changes
Jan 4, 2021
Co-authored-by: Dean Coakley <[email protected]>
| t.Errorf("ParseProxyBuffersSpec(%q) returned an error for valid input", test) | ||
| } | ||
| if test != result { | ||
| t.Errorf("TestParseProxyBuffersSpec(%q) returned %q expected %q", test, result, test) |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Errorf("TestParseProxyBuffersSpec(%q) returned %q expected %q", test, result, test) | |
| t.Errorf("ParseProxyBuffersSpec(%q) returned %q expected %q", test, result, test) |
| for _, test := range invalidInput { | ||
| result, err := ParseProxyBuffersSpec(test) | ||
| if err == nil { | ||
| t.Errorf("TestParseProxyBuffersSpec(%q) didn't return error. Returned: %q", test, result) |
Contributor
There was a problem hiding this comment.
Suggested change
| t.Errorf("TestParseProxyBuffersSpec(%q) didn't return error. Returned: %q", test, result) | |
| t.Errorf("ParseProxyBuffersSpec(%q) didn't return error. Returned: %q", test, result) |
vepatel
approved these changes
Jan 28, 2021
lucacome
added
the
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.