Annotate tcp metrics with k8s object labels #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorcanMcVeigh
requested review from
Dean-Coakley,
lucacome,
mikestephen and
pleshakov
6 tasks
LorcanMcVeigh
force-pushed
the
annotate-tcp
branch
from
2a296fb to
220196f
Compare
Dean-Coakley
reviewed
Dec 1, 2020
pleshakov
suggested changes
Dec 2, 2020
Contributor
pleshakov
left a comment
pleshakov
left a comment
There was a problem hiding this comment.
Please see my comments and suggestions
LorcanMcVeigh
force-pushed
the
annotate-tcp
branch
from
220196f to
0dae384
Compare
Contributor
Author
|
force push was accidental, rebased against master |
pleshakov
suggested changes
Dec 7, 2020
Contributor
pleshakov
left a comment
pleshakov
left a comment
There was a problem hiding this comment.
@LorcanMcVeigh
Please see my comments and suggestions. I also discovered a bug, which I hand't noticed during the previous review :(
Co-authored-by: Michael Pleshakov <[email protected]>
LorcanMcVeigh
force-pushed
the
annotate-tcp
branch
from
64b1f1f to
33473ee
Compare
Dean-Coakley
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add k8s object labels to tcp metrics.
Checklist
Before creating a PR, run through this checklist and mark each as complete.