Skip to content

Check for deprecated/unknown environment variables #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Akshay2191 merged 4 commits into from
Nov 3, 2025
Merged

Check for deprecated/unknown environment variables #1342

Akshay2191 merged 4 commits into from
Nov 3, 2025

Conversation

@Akshay2191
Copy link
Contributor

@Akshay2191 Akshay2191 commented Oct 16, 2025

Implemented a function to validate the environment variables passed are part of the new v3 allowed variables if not it should throw a warning message.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@Akshay2191 Akshay2191 requested a review from a team as a code owner October 16, 2025 10:17
@github-actions github-actions bot added the chore Pull requests for routine tasks label Oct 16, 2025
@codecov
Copy link

codecov bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.24%. Comparing base (383ce95) to head (71c2fdd).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
internal/config/config.go 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
+ Coverage   84.88%   86.24%   +1.35%     
==========================================
  Files         100      102       +2     
  Lines       14520    12531    -1989     
==========================================
- Hits        12325    10807    -1518     
+ Misses       1734     1248     -486     
- Partials      461      476      +15
Files with missing lines Coverage Δ
internal/config/config.go 87.01% <90.47%> (+1.43%) ⬆️

... and 99 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383ce95...71c2fdd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Akshay2191 Akshay2191 self-assigned this Oct 17, 2025
sean-breen
sean-breen reviewed Oct 20, 2025
View reviewed changes
aphralG
aphralG reviewed Oct 20, 2025
View reviewed changes
sean-breen
sean-breen reviewed Oct 24, 2025
View reviewed changes
@Akshay2191 Akshay2191 merged commit b191759 into main Nov 3, 2025
39 checks passed
@Akshay2191 Akshay2191 deleted the check-deprecated-envar branch November 3, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-breen sean-breen sean-breen approved these changes

@spencerugbo spencerugbo spencerugbo approved these changes

@aphralG aphralG aphralG approved these changes

Assignees

@Akshay2191 Akshay2191

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Akshay2191 @sean-breen @spencerugbo @aphralG