Validate file permissions during config apply #1284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
UnwashedMeme
left a comment
UnwashedMeme
left a comment
There was a problem hiding this comment.
The commit message doesn't give any indication why this change is desirable and while for my use case this is nice that doesn't seem obvious that all use cases should block this.
Can you add some text explaining why this is changing?
spencerugbo
changed the title
craigell
approved these changes
Sep 25, 2025
craigell
approved these changes
Sep 25, 2025
aphralG
reviewed
Sep 25, 2025
|
|
||
| permissionErr := fms.validateAndFixPermissions(ctx, fileOverview.GetFiles()) | ||
| if permissionErr != nil { | ||
| return model.PermissionChange, permissionErr |
Contributor
There was a problem hiding this comment.
Could this be the below instead ?
Suggested change
| return model.PermissionChange, permissionErr | |
| return return model.Error, allowedErr |
dhurley
reviewed
Sep 25, 2025
aphralG
approved these changes
Sep 30, 2025
dhurley
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR aims to prevent any files from having execute permissions set during config apply. File permissions are being set by the management plane but this change is an additional check to ensure that no files are written with execute permissions.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)