Skip to content

Restart Subscribe on Connection Reset #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dhurley merged 11 commits into from
Sep 16, 2025
Merged

Restart Subscribe on Connection Reset #1261

dhurley merged 11 commits into from
Sep 16, 2025

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Sep 9, 2025 •
edited
Loading

Proposed changes

  • Cancel and restart subscribe on connection reset.
  • Update FilePlugin to update the FileManagerService connection instead of creating a new one.
  • Update UpdateManifestFile so if the previousManifestFiles map is empty to use the currentFiles
  • Add RollbackManifest bool to determine if the manifest needs to be rollback after a failed config apply
  • More logging

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Sep 9, 2025
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 9, 2025
@aphralG aphralG marked this pull request as ready for review September 11, 2025 14:23
@aphralG aphralG requested a review from a team as a code owner September 11, 2025 14:23
dhurley
dhurley reviewed Sep 11, 2025
View reviewed changes
@aphralG aphralG changed the base branch from main to release-3.3.1 September 15, 2025 15:44
@dhurley dhurley changed the base branch from release-3.3.1 to main September 16, 2025 09:50
@dhurley dhurley merged commit 7588fcf into main Sep 16, 2025
29 checks passed
@dhurley dhurley deleted the cancel-subscribe branch September 16, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@sean-breen sean-breen sean-breen approved these changes

Assignees

@aphralG aphralG

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aphralG @dhurley @craigell @sean-breen