Skip to content

Stricter checks for pseudo-headers :method and :path#1613

Merged
tatsuhiro-t merged 1 commit intonghttp2:masterfrom
mkauf:check_pseudo_header_chars
Sep 4, 2021
Merged

Stricter checks for pseudo-headers :method and :path#1613
tatsuhiro-t merged 1 commit intonghttp2:masterfrom
mkauf:check_pseudo_header_chars

Conversation

@mkauf
Copy link
Copy Markdown
Contributor

@mkauf mkauf commented Aug 31, 2021

Check the allowed characters for ":method" (see RFC 7230, section 3.2.6) and
":path". For ":path", the space and tab characters are now forbidden, but
other special characters are still allowed for compatibility reasons.

Update genvchartbl.py so that it generates the same table as in the code.

Fixes #1611

Check the allowed characters for ":method" (see RFC 7230, section 3.2.6) and
":path". For ":path", the space and tab characters are now forbidden, but
other special characters are still allowed for compatibility reasons.

Update genvchartbl.py so that it generates the same table as in the code.

Fixes nghttp2#1611
@tatsuhiro-t tatsuhiro-t merged commit fcc2033 into nghttp2:master Sep 4, 2021
@tatsuhiro-t
Copy link
Copy Markdown
Member

Thank for PR. Merged now.

@tatsuhiro-t tatsuhiro-t added this to the v1.45.0 milestone Sep 4, 2021
@mkauf mkauf deleted the check_pseudo_header_chars branch September 4, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement stricter checks for allowed characters in pseudo-header values

2 participants