lib/CMakeLists.txt: Make hard-coded static lib suffix optional#1418
Merged
tatsuhiro-t merged 1 commit intonghttp2:masterfrom Dec 8, 2019
vszakats:patch-1
Merged
lib/CMakeLists.txt: Make hard-coded static lib suffix optional#1418tatsuhiro-t merged 1 commit intonghttp2:masterfrom vszakats:patch-1
tatsuhiro-t merged 1 commit intonghttp2:masterfrom
vszakats:patch-1
Conversation
It can be set via the `STATIC_LIB_SUFFIX` variable. This fixes every existing dependent project that relied on the name having no suffix and thus capable of using either a static or shared flavour depending on which one is present on this or how the linker is configured. Ref: #1394
vszakats
changed the title
Contributor
Author
|
Any thoughts/comments? |
Contributor
Author
|
Actually the Travis CI build appears to have finished successfully, not sure why it's still yellow here after 3 weeks. If there is no hope for dealing with this, I'll abandon further Windows builds for curl as they are now unmaintainable with the breakage introduced with 1.40.0. Shipping with an obsolete nghttp2 version isn't something tenable as well. /cc @wrowe @tatsuhiro-t |
Member
|
Sorry for the late relay, I have other things to do these days. I think the change is good. |
Contributor
Author
|
Thank you @tatsuhiro-t! |
jay
added a commit
to jay/curl
that referenced
this pull request
Jul 19, 2021
- Support both nghttp2.lib and nghttp2_static.lib for static nghttp2. nghttp2 briefly changed its static lib name to nghttp2_static, but then made the _static suffix optional. Ref: nghttp2/nghttp2#1394 Ref: nghttp2/nghttp2#1418 Ref: nghttp2/nghttp2#1466 Reported-by: Pierre Yager Fixes curl#7446 Closes #xxxx
jay
added a commit
to curl/curl
that referenced
this pull request
Jul 20, 2021
- Support both nghttp2.lib and nghttp2_static.lib for static nghttp2. nghttp2 briefly changed its static lib name to nghttp2_static, but then made the _static suffix optional. Ref: nghttp2/nghttp2#1394 Ref: nghttp2/nghttp2#1418 Ref: nghttp2/nghttp2#1466 Reported-by: Pierre Yager Fixes #7446 Closes #7447
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be set via the
STATIC_LIB_SUFFIXvariable.This fixes every existing dependent project that relied on the name
having no suffix and thus capable of using either a static or shared
flavour depending on which one is present on this or how the linker
is configured.
Ref: #1394