Fix the bug that stream is closed with wrong error code#1409
Merged
tatsuhiro-t merged 1 commit intomasterfrom Oct 29, 2019
Merged
Fix the bug that stream is closed with wrong error code#1409tatsuhiro-t merged 1 commit intomasterfrom
tatsuhiro-t merged 1 commit intomasterfrom
Conversation
This commit fixes the bug that stream is closed with wrong error code (0). This happens when STREAM or DATA frame with END_STREAM flag set is received and it violates HTTP messaging rule (i.e., content-length does not match) and the other side of stream has been closed. In this case, nghttp2_on_stream_close_callback should be called with nonzero error code, but previously it is called with 0 (NO_ERROR).
tatsuhiro-t
force-pushed
the
fix-wrong-stream-close-error-code
branch
from
c342b4e to
6ce4835
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the bug that stream is closed with wrong error code
(0). This happens when STREAM or DATA frame with END_STREAM flag set
is received and it violates HTTP messaging rule (i.e., content-length
does not match). In this case, nghttp2_on_stream_close_callback
should be called with nonzero error code, but previously it is called
with 0 (NO_ERROR).
Fixes #1408