FTBFS/Regression in nghttp2 1.61.0 => 1.62.0 with gcc 11 #2194
Comments
|
GCC 12 (latest version available for EL7) also fails with the same error. GCC 13 is ok. |
|
gcc-11 probably does not work anymore due to C++20 requirement. gcc-12 works on our GithHub Actions workflow. |
|
According to the config.log, gcc-11 was tested and found to comply with c++20 features when either of According to the report from @xl32, and despite the Github Actions cited above, gcc-12 also fails, and with the same error messages. While this may be gcc's bug, the fact that it affects gcc-12 in RHEL7 (and likely many other similar GNU/Linux distros) suggests this FTBFS will be a problem of more widespread interest. If any further updates to nghttp2 contain fixes for 0-day security vulnerabilities and the like, those distributions will want to roll out patches ASAP; and they will have only gcc-11 or gcc-12 available for the compile. Is it the intention of the nghttp2 developers to roll out nghttp2-1.61.1 and -1.61.2, etc etc., for the foreseeable future, for those distributions which are locked into gcc-11 or gcc-12? Should this c++20 requirement be backed out and moved to nghttp2-2.x as it is not present in nghttp2-1.61? Or add appropriate |
|
Even though gcc says it supports -std=c++20, the actual implementation status of C++ features varies across versions. Also the linux distribution vendors package compilers with their own patches, so it is kind a hard to check the minimum version of gcc. We only support the latest version of nghttp2. It is very hard to support distributions that do have no effort to bring newer compilers to backport to LTS or older releases. Adding ifdef just complicates the source code and we just tired and lose interest in this project, and will eventually abandon its development, that is not what we want. |
|
Saw this in curl also. curl/curl#13650 |
|
Ditto Cygwin |
Needed for Homebrew/homebrew-core#171634 due to nghttp2/nghttp2#2194. I've avoided adding an allowlist for now because I really don't want to see this list grow.
Use gcc 12 to compile h2load as latest nghttp2 does not compile with gcc 11. Refs: nghttp2/nghttp2#2194
Use gcc 12 to compile h2load as latest nghttp2 does not compile with gcc 11. Refs: nghttp2/nghttp2#2194
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
The "solution" I used to make nghttp2 1.62 work is, well, not ideal:
While this is a nice SysAdmin tabletop exercise, it does not lend itself well to a distribution's automation, which may see several non-conflicting packages being updated/compiled in parallel. Replacing gcc from underneath another build process while that build process is actively compiling source files is not what I had wished to accompany my morning coffee. 😄 To be fair, the reverse issue of building packages under gcc-14 that were engineered for earlier standards has been even more "fun" than this one. And this is, in turn, so much nicer than yet another ABI change in libpoppler; but I digress. 😉 |
|
I hope that slackware updates its compilers so that this kind of issues go away. |
While this is true, I am not sure if it's that helpful to the open-source ecosystem to require compilers that are not present in the LTS distributions. GCC 11 was released in 2021 (GCC 10 in Debian bullseye was released in 2020) and while I absolutely agree that from maintainer's perspective it's a PITA to maintain backward-compatibility with older compilers, this leads to a situation where you can't use nghttp2 on reasonably supported distributions. And I am not speaking about the long-term support distros, just the regular stable releases of Debian and Ubuntu (supported for roughly 4 years). I wish you would reconsider the changes between 1.61.0 => 1.62.0; not everyone is at the liberty of upgrading the latest-greatest and this is also making the lives of the distro maintainers much harder than it should be. I am not a C++ programmer, but my guess is that errors like the OP reported and this (Debian Buster with gcc-10) could be circumvented by rewriting the code to a compatible form (there might be a need for #ifdef, but perhaps not?): So, I am kindly asking you to reconsider. |
|
That means OSS developer needs to pay attention to the every LTS distribution which can individually changes its support life time, like 5 years or 10 years and just keep old compiler in tact and refuse to add new compilers. |
|
You should also note downstreams, such as curl, had to revert using 1.62, referencing this issue, as it broke their CI jobs, which probably run on mainstream server distro builds, and are unlikely to have the latest compiler releases, in the interests of stability. |
|
Curl CI uses nghttp2 v1.62.1 without an issue. |
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Compiling nghttp2 1.62.0 fails on stable Linux distros that use gcc 11 as their compiler, such as the stable Slackware 15.0 which uses gcc 11.2.0. Compiling against gcc-13 works fine. The previous versions of nghttp2, 1.61.0 and below, are not affected.
Example:
As a possible workaround, I tried switching between std=c++20 and std=gnu++20 and std=c++17, optionally with
HAVE_CXX20=0, but all of those failed with more errors.The text was updated successfully, but these errors were encountered: