Skip to content

PR in ngtcp2 broke build of nghttp2 #1817

@nerakhon

Description

@nerakhon

ngtcp2/ngtcp2#598 Rename max_udp_payload_size for tx to max_tx_udp_payload_size
needs to be reflected in the nghttp2 code.

shrpx_http3_upstream.cc: In member function 'int shrpx::Http3Upstream::init(const shrpx::UpstreamAddr*, const nghttp2::Address&, const nghttp2::Address&, const ngtcp2_pkt_hd&, const ngtcp2_cid*, const uint8_t*, size_t)':
shrpx_http3_upstream.cc:614:12: error: 'ngtcp2_settings' {aka 'struct ngtcp2_settings'} has no member named 'max_udp_payload_size'; did you mean 'max_tx_udp_payload_size'?
   settings.max_udp_payload_size = SHRPX_QUIC_MAX_UDP_PAYLOAD_SIZE;
            ^~~~~~~~~~~~~~~~~~~~
            max_tx_udp_payload_size
shrpx_http3_upstream.cc: In member function 'int shrpx::Http3Upstream::write_streams()':
shrpx_http3_upstream.cc:741:31: error: 'ngtcp2_conn_get_max_udp_payload_size' was not declared in this scope
   auto max_udp_payload_size = ngtcp2_conn_get_max_udp_payload_size(conn_);
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
shrpx_http3_upstream.cc:741:31: note: suggested alternative: 'ngtcp2_conn_get_max_tx_udp_payload_size'
   auto max_udp_payload_size = ngtcp2_conn_get_max_udp_payload_size(conn_);
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                               ngtcp2_conn_get_max_tx_udp_payload_size
Makefile:2294: recipe for target 'libnghttpx_a-shrpx_http3_upstream.o' failed

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions