You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 3815385
Browse filesBrowse the repository at this point in the historyBrowse files
## Summary
- Unwrap awaited callees in TypeScript extraction and LSP resolution so awaited generic calls retain call edges.
- Adapt upstream TypeScript await commit `e8a46c16`.
## Provenance and gates
- Agent Run: `luna-cbm-ts-await-20260920`; source revision `a43b2201`; worker commit `c540426f`.
- Agent-Workflow reports a valid completion receipt. Independent review, evaluation, acceptance, and integration are pending.
- `git diff --check main...HEAD` passed. No tests were run for this PR request.
## Review follow-up
Addressed in 9efedce.
1. **Incomplete coverage in ts_lsp.c**: `unwrap_await_callee` is now applied in the `ts_eval_expr_type` call_expression branch and in the contextual callback typing, as well as in `resolve_call_at`. There are no other reads of a call_expression's `function` field in the file. New tests: `tslsp_await_generic_call_type_issue2210` (`const v = await load<Foo>(); v.method()`) and `tslsp_await_generic_member_call_issue2210` (`await obj.run<Foo>()`). One caveat: for these shapes, `ts_signature_for_call` already falls back to evaluating the await node, so the two new unwrap sites are consistent with the rest of the file but no test fails without them.
2. **Applied to all languages**: the unwrap in extract_calls.c is now limited to the TypeScript, TSX and JavaScript grammars.
3. **Comment placement**: moved back above `extract_callee_from_fields`.
4. **Test gaps**: added a member-callee extraction test (`extract_ts_await_generic_member_call_issue2210`). Nested awaits are not covered.
The parse shape is confirmed indirectly: removing the ts_lsp.c unwraps fails the PR's original LSP test and the member test. `scripts/test.sh --suites ts_lsp,extraction`: 638 passed. Lint passes.
Separate gaps found along the way, not addressed here: `return obj.run()` inside an async function does not resolve, and `Promise<Foo>` return types are not unwrapped through `await`.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
0 commit comments