Fix hashtag plugin: add support for full width middle dot ・#492
Merged
nfrasser merged 1 commit intonfrasser:mainfrom Oct 25, 2024
Merged
Fix hashtag plugin: add support for full width middle dot ・#492nfrasser merged 1 commit intonfrasser:mainfrom
・#492nfrasser merged 1 commit intonfrasser:mainfrom
Conversation
Pull Request Test Coverage Report for Build 11434698969Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nice to meet you, Thank you for the great OSS you are providing!
I love to using this OSS!
There is one problem in hashtag plugin with Japanese that I would like to fix, and I am sending this pull request.
Issue
・correctly・is a very important symbol in JapaneseExamples
#アラン・チューリング#スター・ウォーズ#レアル・マドリード#コカ・コーラHow to fix
FULLWIDTHMIDDLEDOTtopackages/linkifyjs/src/text.jspackages/linkifyjs/src/scanner.jspackages/linkify-plugin-hashtag/src/hashtag.jstest/spec/linkifyjs/scanner.test.jstest/spec/linkify-plugin-hashtag.test.jsWhat I've checked
I would be very grateful if this issue could be fixed.
I would appreciate your consideration of merge this pull request.