Skip to content

Fix Datamap Functionality#494

Merged
Etschbeijer merged 2 commits intonfdi4plants:mainfrom
caroott:fixDatamap
Jan 22, 2026
Merged

Fix Datamap Functionality#494
Etschbeijer merged 2 commits intonfdi4plants:mainfrom
caroott:fixDatamap

Conversation

@caroott
Copy link
Copy Markdown
Member

@caroott caroott commented Jan 21, 2026

Fixed DataMap → Datamap Property Naming

ARCtrl renamed the DataMap property to Datamap. Updated all references across:

  • SwateControlService.ts: Updated imports and property access
  • SwateView.vue: Updated save handler for datamap processing
  • ArcTreeView.vue: Updated add/delete datamap operations

Fixed Format Field Type Mismatch Bug

Root Cause: The format field of dataContext is sent as a boolean value, but ARCtrl's JSON deserializer expects it to be a string or omitted entirely. This caused JsonController.Datamap.fromJsonString() to fail

  • The format field type issue should ideally be fixed upstream to send strings instead of booleans

@Etschbeijer Etschbeijer self-requested a review January 21, 2026 15:48
@Etschbeijer Etschbeijer self-assigned this Jan 21, 2026
Copy link
Copy Markdown
Collaborator

@Etschbeijer Etschbeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Etschbeijer Etschbeijer merged commit d4c9532 into nfdi4plants:main Jan 22, 2026
caroott added a commit to caroott/ARCitect that referenced this pull request Jan 22, 2026
@caroott caroott mentioned this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants