Regularly check if updates are available on a remote and notify user#469
Regularly check if updates are available on a remote and notify user#469Freymaurer merged 5 commits intonfdi4plants:developerfrom
Conversation
|
Not sure why the PR also shows commits which are already in the developer branch? |
|
Code you do a clean PR? there seems to be an issue in your rebase? 😅 |
|
Yeah let me try |
|
done :-) |
Freymaurer
left a comment
Freymaurer
left a comment
There was a problem hiding this comment.
I don't like how the checkRemoteDirtyStatus is called from vue
I propose two changes:
- Call the interval function inside onMounted
let timer: number | undefined;
onMounted(() => {
timer = window.setInterval(() => {
// side effect here
console.log("tick");
}, 1000);
});
onUnmounted(() => {
clearInterval(timer);
});- A dialog is used to interupt the user in its workflow and awaiting input or notifying of must check changes. I do not think we should call this without user based trigger. Instead please use a "notify" https://quasar.dev/quasar-plugins/notify#introduction
And do not subscribe a watcher to AppProperties.has_dirty_remote. instead just call the notify spawn function directly from the interval if checkRemoteDirtyStatus returns true. Do not save the property somewhere if we do not use it anymore.
|
Hey, thanks again for the quick feedback! 🙂.
Dialog vs Floating notification is a bit more subjective, I went for an interruption with dialog mainly for two reasons:
|
|
@Brilator If you have some time to try this version, I'd be curious as well what you say re user experience |
That the user might miss this if the ARCitect is running in the background is a good point, but we still can set the notify timeout to infinite: then it will require user interaction without blocking the user for action. And a red banner on the bottom left will always draw attention
Again good point. Then maybe we just store the notify return value as reactive property: 
This can also be used to close the notify object: 
|
|
Ok I'll concede on the notification vs dialog ;-). 
I think a flag in the AppProperties still makes the most sense though because it is a global state and used in multiple places (notification from the App.vue, the little exclamation point in the left side menu, updated from the GitSync view: if you do pull, you don't want to wait 5 minutes for the next interval until the little exclamation point disappears). |
|
Agreed! I like the idea of the exclamation mark on the left! Can you center the icon? Then we can merge 
|
|
2 participants
Related to #450 . I hope it'll prevent some annoying merge conflicts 😊