Skip to content

Fixed a code bug#1649

Merged
ErikDanielsson merged 2 commits intonf-core:devfrom
PritamSarbajna:code-fixed
Jun 21, 2022
Merged

Fixed a code bug#1649
ErikDanielsson merged 2 commits intonf-core:devfrom
PritamSarbajna:code-fixed

Conversation

@PritamSarbajna
Copy link
Contributor

@PritamSarbajna PritamSarbajna commented Jun 21, 2022 •
edited
Loading

I have fixed a code bug
it was before - log.info(f"Include statement: include {{ {module_name} }} from '.{os.path.join(*install_folder, module)}/main’")
it is now - log.info(f"Include statement: include {{ {module_name} }} from '.{os.path.join(*install_folder, module)}/main'")

it is a difference between this ’ and this '

it is actually the issue referenced #1640

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2022

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @PritamSarbajna,

It looks like this pull-request is has been made against the PritamSarbajna/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the PritamSarbajna/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@PritamSarbajna PritamSarbajna changed the base branch from master to dev June 21, 2022 14:30
@codecov
Copy link

codecov bot commented Jun 21, 2022 •
edited
Loading

Codecov Report

Merging #1649 (2b76387) into dev (806e0ff) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1649      +/-   ##
==========================================
- Coverage   64.84%   64.81%   -0.04%     
==========================================
  Files          54       54              
  Lines        6270     6270              
==========================================
- Hits         4066     4064       -2     
- Misses       2204     2206       +2
Impacted Files Coverage Δ
nf_core/modules/install.py 66.21% <100.00%> (ø)
nf_core/modules/test_yml_builder.py 48.16% <0.00%> (-0.46%) ⬇️
nf_core/utils.py 80.28% <0.00%> (-0.21%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 806e0ff...2b76387. Read the comment docs.

ErikDanielsson
ErikDanielsson approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch! For next time though, please provide a short description of what you've changed. It makes it easier to review your code.

@ErikDanielsson ErikDanielsson merged commit ef71af8 into nf-core:dev Jun 21, 2022
@PritamSarbajna
Copy link
Contributor Author

PritamSarbajna commented Jun 21, 2022

hey @ErikDanielsson so sorry I had actually written whole description of what I had done in the comment <!-- --> .. So sorry

@ErikDanielsson
Copy link
Contributor

ErikDanielsson commented Jun 21, 2022

Ah, I see! Yeah, that's an easy mistake to make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikDanielsson ErikDanielsson ErikDanielsson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PritamSarbajna @ErikDanielsson