Skip to content

fix(jellyfish/count): support multiple input files - #13079

Draft
barlowa124 wants to merge 1 commit into
nf-core:masterfrom
barlowa124:fix/jellyfish-count-multi-file
Draft

barlowa124 wants to merge 1 commit into
nf-core:masterfrom
barlowa124:fix/jellyfish-count-multi-file

Conversation

@barlowa124

Copy link
Copy Markdown
Contributor

fasta only supports getName() when one file is staged. Nextflow hands multi-file input to the process as a BlankSeparatedList, and paired-end runs abort at line 23 with MissingMethodException.

The script now iterates a normalised file list. Each .gz member gets a dedicated gunzip command and every decompressed name reaches jellyfish count. One-file calls keep their old behaviour. meta.yml describes the input as file-or-list.

Verification comes from sarscov2 - fastq - paired end, which fails against the old script with the same error and succeeds here.

Generated by Devin

PR checklist

Closes #13048

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

Staged multi-file input arrives as a list, so getName() threw
MissingMethodException (BlankSeparatedList). Normalise to a list and
decompress each .gz input individually.

Generated by Devin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

jellyfish/count crashes on paired-end input

1 participant