Repository navigation
fix(jellyfish/count): support multiple input files - #13079
Draft
barlowa124 wants to merge 1 commit into
Draft
barlowa124 wants to merge 1 commit into
barlowa124 wants to merge 1 commit into
Conversation
Staged multi-file input arrives as a list, so getName() threw MissingMethodException (BlankSeparatedList). Normalise to a list and decompress each .gz input individually. Generated by Devin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastaonly supportsgetName()when one file is staged. Nextflow hands multi-file input to the process as aBlankSeparatedList, and paired-end runs abort at line 23 withMissingMethodException.The script now iterates a normalised file list. Each
.gzmember gets a dedicated gunzip command and every decompressed name reachesjellyfish count. One-file calls keep their old behaviour.meta.ymldescribes the input as file-or-list.Verification comes from
sarscov2 - fastq - paired end, which fails against the old script with the same error and succeeds here.Generated by Devin
PR checklist
Closes #13048
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda