Skip to content

nf-core tools v1.9 + PR for coproID v1.1#27

Merged
maxibor merged 35 commits into
nf-core:devfrom
maxibor:dev
Apr 26, 2020
Merged

nf-core tools v1.9 + PR for coproID v1.1#27
maxibor merged 35 commits into
nf-core:devfrom
maxibor:dev

Conversation

@maxibor

@maxibor maxibor commented Apr 20, 2020

Copy link
Copy Markdown
Member
  • Update for nf-core tools v1.9
  • Small fixes to account for tools updates

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/coproid/tree/master/.github/CONTRIBUTING.md

@maxibor maxibor added this to the nf-core/coproID 1.1 milestone Apr 20, 2020
@maxibor
maxibor requested review from apeltzer and jfy133 April 20, 2020 13:18
@maxibor
maxibor changed the base branch from master to dev April 20, 2020 13:19
@maxibor

maxibor commented Apr 21, 2020

Copy link
Copy Markdown
Member Author

This should be ready for review @jfy133 @apeltzer

Comment thread .github/workflows/ci.yml Outdated
Comment thread CHANGELOG.md
Comment thread docs/README.md Outdated
Comment thread docs/README.md Outdated
Comment thread docs/README.md Outdated
Comment thread docs/README.md
Comment thread docs/introduction.md Outdated
Comment thread docs/output.md
Comment thread docs/usage.md
Comment thread docs/usage.md
Comment thread docs/usage.md

@jfy133 jfy133 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few documentation improvement suggestions, but otherwise LGTM

Comment thread docs/usage.md Outdated
@maxibor
maxibor merged commit 6463f1e into nf-core:dev Apr 26, 2020
@maxibor maxibor mentioned this pull request Apr 26, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants