Skip to content

Update mapped basepair count and small fixes#14

Merged
apeltzer merged 10 commits into
nf-core:devfrom
maxibor:dev
May 20, 2019
Merged

Update mapped basepair count and small fixes#14
apeltzer merged 10 commits into
nf-core:devfrom
maxibor:dev

Conversation

@maxibor

@maxibor maxibor commented May 17, 2019

Copy link
Copy Markdown
Member
  • Update mapped basepair count to be quicker and include it in report 2c1be79
  • Remove outdated scripts 8c9ea25
  • Various small fixes

conda env was updated, so docker container needs rebuild -> Travis will fail on this PR #15

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated

@maxibor maxibor changed the title Dev Update mapped basepair count and small fixes May 17, 2019
@maxibor maxibor added the enhancement New feature or request label May 17, 2019
@apeltzer

Copy link
Copy Markdown
Member

conda env was updated, so docker container needs rebuild -> Travis will fail on this PR

What we typically do these days: Just make a simple PR containing only the environment changes and submit that. We merge it, then you open your new PR and this can be properly tested 👍

@maxibor maxibor added this to the nf-core/coproID 1.1 milestone May 17, 2019
@maxibor

maxibor commented May 17, 2019

Copy link
Copy Markdown
Member Author

conda env was updated, so docker container needs rebuild -> Travis will fail on this PR

What we typically do these days: Just make a simple PR containing only the environment changes and submit that. We merge it, then you open your new PR and this can be properly tested 👍

Done with #15

@apeltzer
apeltzer merged commit 7fa8ddd into nf-core:dev May 20, 2019
@maxibor maxibor mentioned this pull request Apr 26, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants