Skip to content

Remove unused DSL1 warning#3671

Merged
bentsherman merged 15 commits intomasterfrom
ben-remove-deprecated-code-3
Mar 14, 2025
Merged

Remove unused DSL1 warning#3671
bentsherman merged 15 commits intomasterfrom
ben-remove-deprecated-code-3

Conversation

@bentsherman
Copy link
Copy Markdown
Member

@bentsherman bentsherman commented Feb 21, 2023 •
edited
Loading

Third batch of changes from #3344 . This PR removes some unused code related to DSL syntax:

  • remove old module include syntax
  • remove from / into syntax for process inputs/outputs
  • remove old process named args syntax
  • remove set qualifier for process inputs/outputs

@pditommaso pditommaso force-pushed the master branch 2 times, most recently from 0d59b4c to b93634e Compare March 11, 2023 11:20
@bentsherman bentsherman changed the title Remove deprecated code (part 3) Remove deprecated DSL syntax Apr 21, 2023
@bentsherman bentsherman linked an issue May 8, 2023 that may be closed by this pull request
DSL1 warning remains #3915
Closed
@bentsherman bentsherman mentioned this pull request Jul 20, 2023
Merged
@pditommaso pditommaso force-pushed the master branch 2 times, most recently from 81f7cb7 to 8a43489 Compare August 20, 2023 20:13
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 18, 2023 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit e1848a5
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67d45105dbfa970008586104

@bentsherman bentsherman changed the title Remove deprecated DSL syntax Remove unused DSL syntax Dec 4, 2023
@bentsherman
Copy link
Copy Markdown
Member Author

bentsherman commented Dec 4, 2023

Okay @pditommaso this PR is ready to go. Now that I have a much deeper understanding of the AST transforms, I'm confident these changes only remove dead code from the DSL1 syntax.

With these simplifications I was able to improve the error checking for process inputs and outputs. So we don't need the hack from #4085 anymore because we can catch it during compilation.

@bentsherman bentsherman changed the title Remove unused DSL syntax Remove unused DSL1 syntax Feb 5, 2025
@bentsherman
Revert unrelated changes
c6b9167 
Signed-off-by: Ben Sherman <[email protected]>
@pditommaso pditommaso force-pushed the master branch 2 times, most recently from 5a93547 to 27345a6 Compare February 10, 2025 21:46
@bentsherman bentsherman changed the title Remove unused DSL1 syntax Remove unused DSL1 warning Mar 10, 2025
@bentsherman bentsherman requested a review from tom-seqera March 10, 2025 16:27
@bentsherman
Copy link
Copy Markdown
Member Author

bentsherman commented Mar 10, 2025

@tom-seqera this PR was originally meant to remove a bunch of DSL1 code, but now I think these changes aren't really needed because the whole v1 parser will be deprecated anyway.

So I have pared down this PR to only remove an outdated DSL1 warning, as reported in the linked issue. If the change makes sense to you, please approve it so that I can merge. Let me know if you have any questions

tom-seqera
tom-seqera approved these changes Mar 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tom-seqera tom-seqera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bentsherman bentsherman merged commit bf18ee8 into master Mar 14, 2025
22 checks passed
@bentsherman bentsherman deleted the ben-remove-deprecated-code-3 branch March 14, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pditommaso pditommaso pditommaso left review comments

+1 more reviewer

@tom-seqera tom-seqera tom-seqera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tom-seqera tom-seqera

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DSL1 warning remains

3 participants

@bentsherman @pditommaso @tom-seqera