Closed
Conversation
Member
Author
|
@pditommaso The tests ran and everything looks good. I will update parts 2 and 3. |
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
0d59b4c to
b93634e
Compare
bentsherman
force-pushed
the
ben-remove-deprecated-code-1
branch
from
57df8da to
700cea1
Compare
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
force-pushed
the
ben-remove-deprecated-code-1
branch
from
9825b7e to
22c08fc
Compare
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
@pditommaso I reduced this PR to focus only on DSL1-related code, since targeting all deprecated code was probably too broad and harder to review. |
bentsherman
changed the title
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
81f7cb7 to
8a43489
Compare
Signed-off-by: Ben Sherman <[email protected]>
Member
Author
|
Think I finally narrowed down this PR to its intended scope. Just removes dead code around the DSL version checks, but all error messages are preserved for user-friendliness. |
Member
Author
|
More importantly, the unit tests no longer use |
Member
|
Merged manually via 2b433a5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First batch of changes from #3344 . Includes the most straightforward changes that don't break a bunch of tests or require much refactoring.
Classes and methods marked as@Deprecatedthat aren't used anywhere else in the code